From 74aa14e7fa57f3b873eb12a15b087fe4549f8cb0 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Tue, 07 Oct 2014 09:55:47 +0000
Subject: [PATCH] PerformanceRunner.java: Extracted local PrintStream variable rather than always calling app.getOutputStream().
---
opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/PerformanceRunner.java | 49 ++++++++++++++++++++++++++-----------------------
1 files changed, 26 insertions(+), 23 deletions(-)
diff --git a/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/PerformanceRunner.java b/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/PerformanceRunner.java
index ef49e50..feb78b2 100644
--- a/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/PerformanceRunner.java
+++ b/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/PerformanceRunner.java
@@ -27,6 +27,7 @@
package com.forgerock.opendj.ldap.tools;
import java.io.IOException;
+import java.io.PrintStream;
import java.lang.management.GarbageCollectorMXBean;
import java.lang.management.ManagementFactory;
import java.util.ArrayList;
@@ -311,31 +312,32 @@
printer.addTitle(title, span);
printer.printTitle();
} else {
- app.getOutputStream().print("Time (seconds)");
- app.getOutputStream().print(",");
- app.getOutputStream().print("Recent throughput (ops/second)");
- app.getOutputStream().print(",");
- app.getOutputStream().print("Average throughput (ops/second)");
- app.getOutputStream().print(",");
- app.getOutputStream().print("Recent response time (milliseconds)");
- app.getOutputStream().print(",");
- app.getOutputStream().print("Average response time (milliseconds)");
+ final PrintStream out = app.getOutputStream();
+ out.print("Time (seconds)");
+ out.print(",");
+ out.print("Recent throughput (ops/second)");
+ out.print(",");
+ out.print("Average throughput (ops/second)");
+ out.print(",");
+ out.print("Recent response time (milliseconds)");
+ out.print(",");
+ out.print("Average response time (milliseconds)");
for (final double percentile : this.percentiles) {
- app.getOutputStream().print(",");
- app.getOutputStream().print(percentile);
- app.getOutputStream().print("% response time (milliseconds)");
+ out.print(",");
+ out.print(percentile);
+ out.print("% response time (milliseconds)");
}
- app.getOutputStream().print(",");
- app.getOutputStream().print("Errors/second");
+ out.print(",");
+ out.print("Errors/second");
if (isAsync) {
- app.getOutputStream().print(",");
- app.getOutputStream().print("Requests/response");
+ out.print(",");
+ out.print("Requests/response");
}
for (final String column : additionalColumns) {
- app.getOutputStream().print(",");
- app.getOutputStream().print(column);
+ out.print(",");
+ out.print(column);
}
- app.getOutputStream().println();
+ out.println();
printer = null;
}
@@ -418,12 +420,13 @@
printer.printRow(strings);
} else {
// Script-friendly.
- app.getOutputStream().print(averageDuration);
+ final PrintStream out = app.getOutputStream();
+ out.print(averageDuration);
for (final String s : strings) {
- app.getOutputStream().print(",");
- app.getOutputStream().print(s);
+ out.print(",");
+ out.print(s);
}
- app.getOutputStream().println();
+ out.println();
}
}
}
--
Gitblit v1.10.0