From 92c409112fc17e9dbd3908b5d0810d38a4edcc96 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Fri, 14 Feb 2014 14:28:38 +0000
Subject: [PATCH] ConditionResultTestCase.java: Made checkstyle happy + fixed the tests failing when run with Maven.
---
opendj-core/src/test/java/org/forgerock/opendj/ldap/ConditionResultTestCase.java | 294 +++++++++++++++++++++++++++-------------------------------
1 files changed, 135 insertions(+), 159 deletions(-)
diff --git a/opendj-core/src/test/java/org/forgerock/opendj/ldap/ConditionResultTestCase.java b/opendj-core/src/test/java/org/forgerock/opendj/ldap/ConditionResultTestCase.java
index 7f0cab7..d18dec9 100644
--- a/opendj-core/src/test/java/org/forgerock/opendj/ldap/ConditionResultTestCase.java
+++ b/opendj-core/src/test/java/org/forgerock/opendj/ldap/ConditionResultTestCase.java
@@ -26,7 +26,11 @@
*/
package org.forgerock.opendj.ldap;
-import java.util.*;
+import java.util.Arrays;
+import java.util.ArrayList;
+import java.util.EnumSet;
+import java.util.Iterator;
+import java.util.List;
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;
@@ -38,172 +42,144 @@
* A set of test cases for the ConditionResult class.
*/
@SuppressWarnings("javadoc")
-public class ConditionResultTestCase extends SdkTestCase
-{
+public class ConditionResultTestCase extends SdkTestCase {
- @DataProvider
- public Iterator<ConditionResult[]> allPermutationsUpTo4Operands()
- {
- final ConditionResult[] values = ConditionResult.values();
+ @DataProvider
+ public Iterator<Object[]> allPermutationsUpTo4Operands() {
+ final ConditionResult[] values = ConditionResult.values();
- final List<ConditionResult[]> results = new ArrayList<ConditionResult[]>();
- results.add(new ConditionResult[0]);
- for (int arrayLength = 1; arrayLength <= 4; arrayLength++)
- {
- final ConditionResult[] template = new ConditionResult[arrayLength];
- allSubPermutations(values, results, template, 0, arrayLength);
- }
- return results.iterator();
- }
-
- private void allSubPermutations(final ConditionResult[] values,
- final List<ConditionResult[]> results, final ConditionResult[] template,
- int currentIndex, int endIndex)
- {
- if (currentIndex < endIndex)
- {
- for (ConditionResult r : values)
- {
- template[currentIndex] = r;
- allSubPermutations(values, results, template, currentIndex + 1, endIndex);
- if (currentIndex + 1 == endIndex)
- {
- results.add(Arrays.copyOf(template, template.length));
+ final List<Object[]> results = new ArrayList<Object[]>();
+ results.add(new Object[] { new ConditionResult[0] });
+ for (int arrayLength = 1; arrayLength <= 4; arrayLength++) {
+ final ConditionResult[] template = new ConditionResult[arrayLength];
+ allSubPermutations(values, results, template, 0, arrayLength);
}
- }
- }
- }
-
- /**
- * Tests some basic assumptions of the enumeration.
- */
- @Test
- public void testBasic()
- {
- assertTrue(3 == values().length);
- assertNotSame(TRUE, FALSE);
- assertNotSame(FALSE, UNDEFINED);
- assertNotSame(UNDEFINED, TRUE);
- }
-
- @Test
- public void testNot()
- {
- assertEquals(not(FALSE), TRUE);
- assertEquals(not(TRUE), FALSE);
- assertEquals(not(UNDEFINED), UNDEFINED);
- }
-
- @Test
- public void testAnd()
- {
- assertEquals(and(), TRUE);
-
- assertEquals(and(TRUE), TRUE);
- assertEquals(and(FALSE), FALSE);
- assertEquals(and(UNDEFINED), UNDEFINED);
-
- assertEquals(and(TRUE, TRUE), TRUE);
- assertEquals(and(FALSE, FALSE), FALSE);
- assertEquals(and(UNDEFINED, UNDEFINED), UNDEFINED);
-
- assertAndIsCommutative(TRUE, FALSE, FALSE);
- assertAndIsCommutative(TRUE, UNDEFINED, UNDEFINED);
- assertAndIsCommutative(FALSE, UNDEFINED, FALSE);
- }
-
- private void assertAndIsCommutative(ConditionResult operand1,
- ConditionResult operand2, ConditionResult expectedResult)
- {
- assertEquals(and(operand1, operand2), expectedResult);
- assertEquals(and(operand2, operand1), expectedResult);
- }
-
- @Test(dataProvider = "allPermutationsUpTo4Operands")
- public void testVarargsAndIsCommutative(ConditionResult... operands)
- {
- if (operands.length == 0)
- {
- assertEquals(and(operands), and());
- return;
+ return results.iterator();
}
- final EnumSet<ConditionResult> ops = EnumSet.copyOf(Arrays.asList(operands));
- if (ops.contains(FALSE))
- {
- assertEquals(and(operands), FALSE);
- }
- else if (ops.contains(UNDEFINED))
- {
- assertEquals(and(operands), UNDEFINED);
- }
- else
- {
- assertEquals(and(operands), TRUE);
- }
- }
-
- @Test
- public void testOr()
- {
- assertEquals(or(), FALSE);
-
- assertEquals(or(TRUE), TRUE);
- assertEquals(or(FALSE), FALSE);
- assertEquals(or(UNDEFINED), UNDEFINED);
-
- assertEquals(or(TRUE, TRUE), TRUE);
- assertEquals(or(FALSE, FALSE), FALSE);
- assertEquals(or(UNDEFINED, UNDEFINED), UNDEFINED);
-
- assertOrIsCommutative(TRUE, FALSE, TRUE);
- assertOrIsCommutative(TRUE, UNDEFINED, TRUE);
- assertOrIsCommutative(FALSE, UNDEFINED, UNDEFINED);
- }
-
- private void assertOrIsCommutative(ConditionResult operand1,
- ConditionResult operand2, ConditionResult expectedResult)
- {
- assertEquals(or(operand1, operand2), expectedResult);
- assertEquals(or(operand2, operand1), expectedResult);
- }
-
- @Test(dataProvider = "allPermutationsUpTo4Operands")
- public void testVarargsOrIsCommutative(ConditionResult... operands)
- {
- if (operands.length == 0)
- {
- assertEquals(or(operands), or());
- return;
+ private void allSubPermutations(ConditionResult[] values, final List<Object[]> results,
+ final ConditionResult[] template, int currentIndex, int endIndex) {
+ if (currentIndex < endIndex) {
+ for (ConditionResult r : values) {
+ template[currentIndex] = r;
+ allSubPermutations(values, results, template, currentIndex + 1, endIndex);
+ if (currentIndex + 1 == endIndex) {
+ results.add(new Object[] {
+ Arrays.copyOf(template, template.length, ConditionResult[].class)
+ });
+ }
+ }
+ }
}
- final EnumSet<ConditionResult> ops = EnumSet.copyOf(Arrays.asList(operands));
- if (ops.contains(TRUE))
- {
- assertEquals(or(operands), TRUE);
+ /**
+ * Tests some basic assumptions of the enumeration.
+ */
+ @Test
+ public void testBasic() {
+ assertEquals(values().length, 3);
+ assertNotSame(TRUE, FALSE);
+ assertNotSame(FALSE, UNDEFINED);
+ assertNotSame(UNDEFINED, TRUE);
}
- else if (ops.contains(UNDEFINED))
- {
- assertEquals(or(operands), UNDEFINED);
- }
- else
- {
- assertEquals(or(operands), FALSE);
- }
- }
- @Test
- public void testValueOf()
- {
- assertEquals(valueOf(true), TRUE);
- assertEquals(valueOf(false), FALSE);
- }
+ @Test
+ public void testNot() {
+ assertEquals(not(FALSE), TRUE);
+ assertEquals(not(TRUE), FALSE);
+ assertEquals(not(UNDEFINED), UNDEFINED);
+ }
- @Test
- public void testToBoolean()
- {
- assertEquals(TRUE.toBoolean(), true);
- assertEquals(FALSE.toBoolean(), false);
- assertEquals(UNDEFINED.toBoolean(), false);
- }
+ @Test
+ public void testAnd() {
+ assertEquals(and(), TRUE);
+
+ assertEquals(and(TRUE), TRUE);
+ assertEquals(and(FALSE), FALSE);
+ assertEquals(and(UNDEFINED), UNDEFINED);
+
+ assertEquals(and(TRUE, TRUE), TRUE);
+ assertEquals(and(FALSE, FALSE), FALSE);
+ assertEquals(and(UNDEFINED, UNDEFINED), UNDEFINED);
+
+ assertAndIsCommutative(TRUE, FALSE, FALSE);
+ assertAndIsCommutative(TRUE, UNDEFINED, UNDEFINED);
+ assertAndIsCommutative(FALSE, UNDEFINED, FALSE);
+ }
+
+ private void assertAndIsCommutative(ConditionResult operand1, ConditionResult operand2,
+ ConditionResult expectedResult) {
+ assertEquals(and(operand1, operand2), expectedResult);
+ assertEquals(and(operand2, operand1), expectedResult);
+ }
+
+ @Test(dataProvider = "allPermutationsUpTo4Operands")
+ public void testVarargsAndIsCommutative(ConditionResult[] operands) {
+ if (operands.length == 0) {
+ assertEquals(and(operands), and());
+ return;
+ }
+
+ final EnumSet<ConditionResult> ops = EnumSet.copyOf(Arrays.asList(operands));
+ if (ops.contains(FALSE)) {
+ assertEquals(and(operands), FALSE);
+ } else if (ops.contains(UNDEFINED)) {
+ assertEquals(and(operands), UNDEFINED);
+ } else {
+ assertEquals(and(operands), TRUE);
+ }
+ }
+
+ @Test
+ public void testOr() {
+ assertEquals(or(), FALSE);
+
+ assertEquals(or(TRUE), TRUE);
+ assertEquals(or(FALSE), FALSE);
+ assertEquals(or(UNDEFINED), UNDEFINED);
+
+ assertEquals(or(TRUE, TRUE), TRUE);
+ assertEquals(or(FALSE, FALSE), FALSE);
+ assertEquals(or(UNDEFINED, UNDEFINED), UNDEFINED);
+
+ assertOrIsCommutative(TRUE, FALSE, TRUE);
+ assertOrIsCommutative(TRUE, UNDEFINED, TRUE);
+ assertOrIsCommutative(FALSE, UNDEFINED, UNDEFINED);
+ }
+
+ private void assertOrIsCommutative(ConditionResult operand1, ConditionResult operand2,
+ ConditionResult expectedResult) {
+ assertEquals(or(operand1, operand2), expectedResult);
+ assertEquals(or(operand2, operand1), expectedResult);
+ }
+
+ @Test(dataProvider = "allPermutationsUpTo4Operands")
+ public void testVarargsOrIsCommutative(ConditionResult[] operands) {
+ if (operands.length == 0) {
+ assertEquals(or(operands), or());
+ return;
+ }
+
+ final EnumSet<ConditionResult> ops = EnumSet.copyOf(Arrays.asList(operands));
+ if (ops.contains(TRUE)) {
+ assertEquals(or(operands), TRUE);
+ } else if (ops.contains(UNDEFINED)) {
+ assertEquals(or(operands), UNDEFINED);
+ } else {
+ assertEquals(or(operands), FALSE);
+ }
+ }
+
+ @Test
+ public void testValueOf() {
+ assertEquals(valueOf(true), TRUE);
+ assertEquals(valueOf(false), FALSE);
+ }
+
+ @Test
+ public void testToBoolean() {
+ assertEquals(TRUE.toBoolean(), true);
+ assertEquals(FALSE.toBoolean(), false);
+ assertEquals(UNDEFINED.toBoolean(), false);
+ }
}
--
Gitblit v1.10.0