From b13e2eba95ed4090fe722456234ca812bb073ebc Mon Sep 17 00:00:00 2001
From: Matthew Swift <matthew.swift@forgerock.com>
Date: Fri, 27 Sep 2013 22:14:38 +0000
Subject: [PATCH] Fix very minor compiler warnings in Eclipse.
---
opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/Controls.java | 1 -
opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/Modify.java | 1 -
opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/Search.java | 1 -
opendj3/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPModify.java | 1 -
opendj3/opendj-ldap-toolkit/src/test/java/com/forgerock/opendj/ldap/tools/ConnectionFactoryProviderTest.java | 1 +
opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldif/LDIFTestCase.java | 7 -------
opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/GetADChangeNotifications.java | 1 -
opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/EntryTestCase.java | 2 +-
opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/GetInfo.java | 1 -
opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/AbstractAsynchronousConnectionTestCase.java | 6 +++---
opendj3/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPSearch.java | 1 -
11 files changed, 5 insertions(+), 18 deletions(-)
diff --git a/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/Controls.java b/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/Controls.java
index 29abfa3..8220835 100644
--- a/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/Controls.java
+++ b/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/Controls.java
@@ -94,7 +94,6 @@
* specific credentials to connect, and ensure that your application has access
* to use the LDAP controls needed.
*/
-@SuppressWarnings("resource")
public final class Controls {
/**
diff --git a/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/GetADChangeNotifications.java b/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/GetADChangeNotifications.java
index ba2e99e..7a11937 100644
--- a/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/GetADChangeNotifications.java
+++ b/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/GetADChangeNotifications.java
@@ -61,7 +61,6 @@
*
* <p>The {@code baseDN} must be the root of a naming context in this example.
*/
-@SuppressWarnings("resource")
public final class GetADChangeNotifications {
/**
* Main method.
diff --git a/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/GetInfo.java b/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/GetInfo.java
index 439974b..fd11a59 100644
--- a/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/GetInfo.java
+++ b/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/GetInfo.java
@@ -38,7 +38,6 @@
/**
* Demonstrates accessing server information about capabilities and schema.
*/
-@SuppressWarnings("resource")
public final class GetInfo {
// Connection information
private static String host;
diff --git a/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/Modify.java b/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/Modify.java
index effc259..f7397e7 100644
--- a/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/Modify.java
+++ b/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/Modify.java
@@ -50,7 +50,6 @@
* <host> <port> <username> <password> [<ldifFile>]
* </pre>
*/
-@SuppressWarnings("resource")
public final class Modify {
/**
* Main method.
diff --git a/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/Search.java b/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/Search.java
index c23ec1e..475e05b 100644
--- a/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/Search.java
+++ b/opendj3/opendj-ldap-sdk-examples/src/main/java/org/forgerock/opendj/examples/Search.java
@@ -50,7 +50,6 @@
* <baseDN> <scope> <filter> [<attibute> <attribute> ...]
* </pre>
*/
-@SuppressWarnings("resource")
public final class Search {
/**
* Main method.
diff --git a/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/AbstractAsynchronousConnectionTestCase.java b/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/AbstractAsynchronousConnectionTestCase.java
index 6966aa4..f8c65c2 100644
--- a/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/AbstractAsynchronousConnectionTestCase.java
+++ b/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/AbstractAsynchronousConnectionTestCase.java
@@ -61,7 +61,7 @@
* Unit test for AbstractAsynchronousConnection. The tests verify that all
* synchronous operation methods delegate to the equivalent asynchronous method.
*/
-@SuppressWarnings({ "javadoc", "resource" })
+@SuppressWarnings("javadoc")
public class AbstractAsynchronousConnectionTestCase extends SdkTestCase {
private final class MockConnection extends AbstractAsynchronousConnection {
@@ -501,8 +501,8 @@
Responses.newSearchResultEntry("cn=test,ou=org"));
final SearchRequest request = Requests.newSingleEntrySearchRequest("cn=test", SearchScope.BASE_OBJECT,
"(objectClass=*)");
+ @SuppressWarnings("unchecked")
ResultHandler<SearchResultEntry> handler = mock(ResultHandler.class);
-
try {
mockConnection.searchSingleEntryAsync(request, handler).get();
failWasExpected(MultipleEntriesFoundException.class);
@@ -530,8 +530,8 @@
final Connection mockConnection = new MockConnection(ResultCode.UNWILLING_TO_PERFORM);
final SearchRequest request =
Requests.newSingleEntrySearchRequest("cn=test", SearchScope.BASE_OBJECT, "(objectClass=*)");
+ @SuppressWarnings("unchecked")
ResultHandler<SearchResultEntry> handler = mock(ResultHandler.class);
-
try {
mockConnection.searchSingleEntryAsync(request, handler).get();
failWasExpected(ErrorResultException.class);
diff --git a/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/EntryTestCase.java b/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/EntryTestCase.java
index 009f2c7..5721f28 100644
--- a/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/EntryTestCase.java
+++ b/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldap/EntryTestCase.java
@@ -43,7 +43,7 @@
/**
* Test {@code Entry}.
*/
-@SuppressWarnings({ "javadoc", "resource" })
+@SuppressWarnings("javadoc")
public final class EntryTestCase extends SdkTestCase {
private static interface EntryFactory {
diff --git a/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldif/LDIFTestCase.java b/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldif/LDIFTestCase.java
index a4b5ac8..d267e62 100644
--- a/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldif/LDIFTestCase.java
+++ b/opendj3/opendj-ldap-sdk/src/test/java/org/forgerock/opendj/ldif/LDIFTestCase.java
@@ -2360,7 +2360,6 @@
*
* @throws Exception
*/
- @SuppressWarnings("resource")
@Test(expectedExceptions = DecodeException.class)
public final void testLdifPatchInvalidChangeRecord() throws Exception {
// @formatter:off
@@ -2399,7 +2398,6 @@
*
* @throws Exception
*/
- @SuppressWarnings("resource")
@Test(expectedExceptions = DecodeException.class)
public final void testFailFastPatchOnModifyRequestFailsDueToWrongDN() throws Exception {
@@ -2437,7 +2435,6 @@
*
* @throws Exception
*/
- @SuppressWarnings("resource")
@Test()
public final void testOverwritePatchOnModifyRequestSucceedsEvenIfWrongDN() throws Exception {
@@ -2485,7 +2482,6 @@
*
* @throws Exception
*/
- @SuppressWarnings("resource")
@Test(expectedExceptions = DecodeException.class)
public final void testFailFastPatchOnModifyDNRequestFailsDueToWrongDN() throws Exception {
final RejectedChangeRecordListener listener = RejectedChangeRecordListener.FAIL_FAST;
@@ -2522,7 +2518,6 @@
*
* @throws Exception
*/
- @SuppressWarnings("resource")
@Test()
public final void testOverwritePatchOnModifyDNRequestSucceedsEvenWithWrongDN() throws Exception {
final RejectedChangeRecordListener listener = RejectedChangeRecordListener.OVERWRITE;
@@ -2569,7 +2564,6 @@
*
* @throws Exception
*/
- @SuppressWarnings("resource")
@Test(expectedExceptions = DecodeException.class)
public final void testFailFastPatchOnModifyDNRequestFailsDueToDuplicateEntry() throws Exception {
final RejectedChangeRecordListener listener = RejectedChangeRecordListener.FAIL_FAST;
@@ -2616,7 +2610,6 @@
*
* @throws Exception
*/
- @SuppressWarnings("resource")
@Test()
public final void testOverwritePatchOnModifyDNRequestSucceedsEvenWithDuplicateEntry() throws Exception {
final RejectedChangeRecordListener listener = RejectedChangeRecordListener.OVERWRITE;
diff --git a/opendj3/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPModify.java b/opendj3/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPModify.java
index 94f6e23..720f1d4 100644
--- a/opendj3/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPModify.java
+++ b/opendj3/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPModify.java
@@ -232,7 +232,6 @@
return verbose.isPresent();
}
- @SuppressWarnings("resource")
private int run(final String[] args) {
// Create the command-line argument parser for use with this
// program.
diff --git a/opendj3/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPSearch.java b/opendj3/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPSearch.java
index 4c6873b..309a13b 100644
--- a/opendj3/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPSearch.java
+++ b/opendj3/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/LDAPSearch.java
@@ -221,7 +221,6 @@
return verbose.isPresent();
}
- @SuppressWarnings("resource")
private int run(final String[] args, final boolean returnMatchingEntries) {
// Create the command-line argument parser for use with this
// program.
diff --git a/opendj3/opendj-ldap-toolkit/src/test/java/com/forgerock/opendj/ldap/tools/ConnectionFactoryProviderTest.java b/opendj3/opendj-ldap-toolkit/src/test/java/com/forgerock/opendj/ldap/tools/ConnectionFactoryProviderTest.java
index 25f166e..afcc9df 100644
--- a/opendj3/opendj-ldap-toolkit/src/test/java/com/forgerock/opendj/ldap/tools/ConnectionFactoryProviderTest.java
+++ b/opendj3/opendj-ldap-toolkit/src/test/java/com/forgerock/opendj/ldap/tools/ConnectionFactoryProviderTest.java
@@ -36,6 +36,7 @@
import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;
+@SuppressWarnings("javadoc")
public class ConnectionFactoryProviderTest extends ToolsTestCase {
@Mock
--
Gitblit v1.10.0