From b5b40727c0d42ed22db4e1bb0961656e62c65dc9 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Wed, 01 Oct 2014 14:39:08 +0000
Subject: [PATCH] Removed useless "TODO Auto-generated method stub" comments.
---
opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/EqualityIndexer.java | 7
/dev/null | 190 --------------------------------------
opendj-sdk/opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/replication/plugin/StateMachineTest.java | 50 +++++----
opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/ApproximateIndexer.java | 5
opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/OrderingIndexer.java | 5
opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/SubstringIndexer.java | 5
6 files changed, 36 insertions(+), 226 deletions(-)
diff --git a/opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/ApproximateIndexer.java b/opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/ApproximateIndexer.java
index 615deeb..ce3e491 100644
--- a/opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/ApproximateIndexer.java
+++ b/opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/ApproximateIndexer.java
@@ -46,7 +46,7 @@
/**
* The attribute type approximate matching rule.
*/
- private MatchingRule approximateRule;
+ private final MatchingRule approximateRule;
/**
* Create a new attribute approximate indexer for the given index
@@ -63,8 +63,7 @@
@Override
public String getIndexID()
{
- // TODO Auto-generated method stub
- throw new RuntimeException();
+ throw new RuntimeException("Code is not implemented");
}
/** {@inheritDoc} */
diff --git a/opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/EqualityIndexer.java b/opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/EqualityIndexer.java
index a1b9d33..cb7cf8f 100644
--- a/opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/EqualityIndexer.java
+++ b/opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/EqualityIndexer.java
@@ -33,8 +33,8 @@
import org.forgerock.opendj.ldap.DecodeException;
import org.forgerock.opendj.ldap.schema.Schema;
import org.forgerock.opendj.ldap.spi.IndexingOptions;
-import org.opends.server.api.MatchingRule;
import org.opends.server.api.ExtensibleIndexer;
+import org.opends.server.api.MatchingRule;
import org.opends.server.types.AttributeType;
/**
@@ -47,7 +47,7 @@
* The attribute type equality matching rule which is also the
* comparator for the index keys generated by this class.
*/
- private MatchingRule equalityRule;
+ private final MatchingRule equalityRule;
/**
* Create a new attribute equality indexer for the given index configuration.
@@ -63,8 +63,7 @@
@Override
public String getIndexID()
{
- // TODO Auto-generated method stub
- throw new RuntimeException();
+ throw new RuntimeException("Code is not implemented");
}
/** {@inheritDoc} */
diff --git a/opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/OrderingIndexer.java b/opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/OrderingIndexer.java
index 5fa05ae..6d440aa 100644
--- a/opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/OrderingIndexer.java
+++ b/opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/OrderingIndexer.java
@@ -47,7 +47,7 @@
* The attribute type ordering matching rule which is also the
* comparator for the index keys generated by this class.
*/
- private MatchingRule orderingRule;
+ private final MatchingRule orderingRule;
/**
@@ -64,8 +64,7 @@
@Override
public String getIndexID()
{
- // TODO Auto-generated method stub
- throw new RuntimeException();
+ throw new RuntimeException("Code is not implemented");
}
/** {@inheritDoc} */
diff --git a/opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/SubstringIndexer.java b/opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/SubstringIndexer.java
index 1c7eca5..2c9b2c2 100644
--- a/opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/SubstringIndexer.java
+++ b/opendj-sdk/opendj3-server-dev/src/server/org/opends/server/backends/jeb/SubstringIndexer.java
@@ -43,7 +43,7 @@
public class SubstringIndexer extends ExtensibleIndexer
{
- private MatchingRule substringRule;
+ private final MatchingRule substringRule;
/**
* Create a new attribute substring indexer for the given index configuration.
@@ -60,8 +60,7 @@
@Override
public String getIndexID()
{
- // TODO Auto-generated method stub
- throw new RuntimeException();
+ throw new RuntimeException("Code is not implemented");
}
/** {@inheritDoc} */
diff --git a/opendj-sdk/opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/replication/plugin/MultimasterReplicationFakeConf.java b/opendj-sdk/opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/replication/plugin/MultimasterReplicationFakeConf.java
deleted file mode 100644
index 5de8d82..0000000
--- a/opendj-sdk/opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/replication/plugin/MultimasterReplicationFakeConf.java
+++ /dev/null
@@ -1,190 +0,0 @@
-/*
- * CDDL HEADER START
- *
- * The contents of this file are subject to the terms of the
- * Common Development and Distribution License, Version 1.0 only
- * (the "License"). You may not use this file except in compliance
- * with the License.
- *
- * You can obtain a copy of the license at legal-notices/CDDLv1_0.txt
- * or http://forgerock.org/license/CDDLv1.0.html.
- * See the License for the specific language governing permissions
- * and limitations under the License.
- *
- * When distributing Covered Code, include this CDDL HEADER in each
- * file and include the License file at legal-notices/CDDLv1_0.txt.
- * If applicable, add the following below this CDDL HEADER, with the
- * fields enclosed by brackets "[]" replaced with your own identifying
- * information:
- * Portions Copyright [yyyy] [name of copyright owner]
- *
- * CDDL HEADER END
- *
- *
- * Copyright 2009 Sun Microsystems, Inc.
- * Portions Copyright 2011-2014 ForgeRock AS.
- */
-package org.opends.server.replication.plugin;
-
-import org.opends.server.admin.server.ConfigurationAddListener;
-import org.opends.server.admin.server.ConfigurationChangeListener;
-import org.opends.server.admin.server.ConfigurationDeleteListener;
-import org.opends.server.admin.std.server.ReplicationDomainCfg;
-import org.opends.server.admin.std.server.ReplicationServerCfg;
-import org.opends.server.admin.std.server.ReplicationSynchronizationProviderCfg;
-import org.opends.server.admin.std.server.SynchronizationProviderCfg;
-import org.forgerock.opendj.config.server.ConfigException;
-import org.opends.server.types.DN;
-
-public class MultimasterReplicationFakeConf implements
- ReplicationSynchronizationProviderCfg
-{
-
- public void addReplicationChangeListener(
- ConfigurationChangeListener<ReplicationSynchronizationProviderCfg> listener)
- {
- // TODO Auto-generated method stub
-
- }
-
- public void addReplicationDomainAddListener(
- ConfigurationAddListener<ReplicationDomainCfg> listener)
- throws ConfigException
- {
- // TODO Auto-generated method stub
-
- }
-
- public void addReplicationDomainDeleteListener(
- ConfigurationDeleteListener<ReplicationDomainCfg> listener)
- throws ConfigException
- {
- // TODO Auto-generated method stub
-
- }
-
- public void addReplicationServerAddListener(
- ConfigurationAddListener<ReplicationServerCfg> listener)
- throws ConfigException
- {
- // TODO Auto-generated method stub
-
- }
-
- public void addReplicationServerDeleteListener(
- ConfigurationDeleteListener<ReplicationServerCfg> listener)
- throws ConfigException
- {
- // TODO Auto-generated method stub
-
- }
-
- public Class<? extends ReplicationSynchronizationProviderCfg> configurationClass()
- {
- // TODO Auto-generated method stub
- return null;
- }
-
- public String getJavaClass()
- {
- // TODO Auto-generated method stub
- return null;
- }
-
- public int getNumUpdateReplayThreads()
- {
- return 1;
- }
-
- public ReplicationDomainCfg getReplicationDomain(String name)
- throws ConfigException
- {
- // TODO Auto-generated method stub
- return null;
- }
-
- public ReplicationServerCfg getReplicationServer() throws ConfigException
- {
- // TODO Auto-generated method stub
- return null;
- }
-
- public boolean hasReplicationServer()
- {
- // TODO Auto-generated method stub
- return false;
- }
-
- public String[] listReplicationDomains()
- {
- // TODO Auto-generated method stub
- return null;
- }
-
- public void removeReplicationChangeListener(
- ConfigurationChangeListener<ReplicationSynchronizationProviderCfg> listener)
- {
- // TODO Auto-generated method stub
-
- }
-
- public void removeReplicationDomainAddListener(
- ConfigurationAddListener<ReplicationDomainCfg> listener)
- {
- // TODO Auto-generated method stub
-
- }
-
- public void removeReplicationDomainDeleteListener(
- ConfigurationDeleteListener<ReplicationDomainCfg> listener)
- {
- // TODO Auto-generated method stub
-
- }
-
- public void removeReplicationServerAddListener(
- ConfigurationAddListener<ReplicationServerCfg> listener)
- {
- // TODO Auto-generated method stub
-
- }
-
- public void removeReplicationServerDeleteListener(
- ConfigurationDeleteListener<ReplicationServerCfg> listener)
- {
- // TODO Auto-generated method stub
-
- }
-
- public void addChangeListener(
- ConfigurationChangeListener<SynchronizationProviderCfg> listener)
- {
- // TODO Auto-generated method stub
-
- }
-
- public boolean isEnabled()
- {
- // TODO Auto-generated method stub
- return false;
- }
-
- public void removeChangeListener(
- ConfigurationChangeListener<SynchronizationProviderCfg> listener)
- {
- // TODO Auto-generated method stub
-
- }
-
- public DN dn()
- {
- // TODO Auto-generated method stub
- return null;
- }
-
- public long getConnectionTimeout()
- {
- return 5000;
- }
-
-}
diff --git a/opendj-sdk/opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/replication/plugin/StateMachineTest.java b/opendj-sdk/opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/replication/plugin/StateMachineTest.java
index fe42527..1377946 100644
--- a/opendj-sdk/opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/replication/plugin/StateMachineTest.java
+++ b/opendj-sdk/opendj3-server-dev/tests/unit-tests-testng/src/server/org/opends/server/replication/plugin/StateMachineTest.java
@@ -34,12 +34,13 @@
import java.util.concurrent.atomic.AtomicBoolean;
import org.forgerock.i18n.LocalizableMessage;
+import org.forgerock.i18n.slf4j.LocalizedLogger;
import org.opends.server.TestCaseUtils;
import org.opends.server.admin.server.ConfigurationChangeListener;
+import org.opends.server.admin.std.server.ReplicationSynchronizationProviderCfg;
import org.opends.server.admin.std.server.SynchronizationProviderCfg;
import org.opends.server.api.SynchronizationProvider;
import org.opends.server.core.DirectoryServer;
-import org.forgerock.i18n.slf4j.LocalizedLogger;
import org.opends.server.replication.ReplicationTestCase;
import org.opends.server.replication.common.CSNGenerator;
import org.opends.server.replication.common.DSInfo;
@@ -57,6 +58,7 @@
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;
+import static org.mockito.Mockito.*;
import static org.opends.server.TestCaseUtils.*;
import static org.testng.Assert.*;
@@ -68,7 +70,8 @@
public class StateMachineTest extends ReplicationTestCase
{
- private static final String EXAMPLE_DN = "dc=example,dc=com"; // Server id definitions
+ /** Server id definitions. */
+ private static final String EXAMPLE_DN = "dc=example,dc=com";
private static DN EXAMPLE_DN_;
private static final int DS1_ID = 1;
@@ -82,7 +85,7 @@
private ReplicationServer rs1;
/** The tracer object for the debug logger */
private static final LocalizedLogger logger = LocalizedLogger.getLoggerForThisClass();
- private int initWindow = 100;
+ private final int initWindow = 100;
private void debugInfo(String s)
{
@@ -193,8 +196,7 @@
* server
*/
@SuppressWarnings("unchecked")
- private LDAPReplicationDomain createReplicationDomain(int dsId)
- throws Exception
+ private LDAPReplicationDomain createReplicationDomain(int dsId) throws Exception
{
SortedSet<String> replServers = new TreeSet<String>();
replServers.add("localhost:" + rs1Port);
@@ -206,9 +208,9 @@
DirectoryServer.getSynchronizationProviders().get(0);
if (provider instanceof ConfigurationChangeListener)
{
- ConfigurationChangeListener<MultimasterReplicationFakeConf> mmr =
- (ConfigurationChangeListener<MultimasterReplicationFakeConf>) provider;
- mmr.applyConfigurationChange(new MultimasterReplicationFakeConf());
+ ConfigurationChangeListener<ReplicationSynchronizationProviderCfg> mmr =
+ (ConfigurationChangeListener<ReplicationSynchronizationProviderCfg>) provider;
+ mmr.applyConfigurationChange(mock(ReplicationSynchronizationProviderCfg.class));
}
return replicationDomain;
@@ -730,12 +732,14 @@
private class BrokerInitializer
{
- private ReplicationBroker rb = null;
+ private ReplicationBroker rb;
private int serverId = -1;
- private long userId = 0;
- private int destId = -1; // Server id of server to initialize
- private long nEntries = -1; // Number of entries to send to dest
- private boolean createReader = false;
+ private long userId;
+ /** Server id of server to initialize. */
+ private int destId = -1;
+ /** Number of entries to send to dest. */
+ private long nEntries = -1;
+ private boolean createReader;
/**
* If the BrokerInitializer is to be used for a lot of entries to send
@@ -744,7 +748,7 @@
* he wants. If not enabled, the user is responsible to call the receive
* method of the broker himself.
*/
- private BrokerReader reader = null;
+ private BrokerReader reader;
/**
* Creates a broker initializer. Also creates a reader according to request
@@ -850,11 +854,11 @@
private class BrokerWriter extends Thread
{
- private ReplicationBroker rb = null;
+ private ReplicationBroker rb;
private int serverId = -1;
- private long userId = 0;
+ private long userId;
private AtomicBoolean shutdown = new AtomicBoolean(false);
- /** The writer starts suspended */
+ /** The writer starts suspended. */
private AtomicBoolean suspended = new AtomicBoolean(true);
/**
* Tells a sending session is finished. A session is sending messages
@@ -862,11 +866,11 @@
* method runs.
*/
private AtomicBoolean sessionDone = new AtomicBoolean(true);
- private boolean careAboutAmountOfChanges = false;
- /** Number of sent changes */
- private int nChangesSent = 0;
- private int nChangesSentLimit = 0;
- CSNGenerator gen = null;
+ private boolean careAboutAmountOfChanges;
+ /** Number of sent changes. */
+ private int nChangesSent;
+ private int nChangesSentLimit;
+ private CSNGenerator gen;
private Object sleeper = new Object();
/**
* If the BrokerWriter is to be used for a lot of changes to send (which is
@@ -875,7 +879,7 @@
* If not enabled, the user is responsible to call the receive method of
* the broker himself.
*/
- private BrokerReader reader = null;
+ private BrokerReader reader;
/** Creates a broker writer. Also creates a reader according to request */
public BrokerWriter(ReplicationBroker rb, int serverId,
--
Gitblit v1.10.0