From bdc6480a8eb2ccd097b14ed76d77703d1eed32a4 Mon Sep 17 00:00:00 2001
From: Matthew Swift <matthew.swift@forgerock.com>
Date: Mon, 30 May 2016 08:23:47 +0000
Subject: [PATCH] Minor code cleanup
---
opendj-server-legacy/src/main/java/org/opends/server/loggers/TextHTTPAccessLogPublisher.java | 2 +-
opendj-server-legacy/src/main/java/org/opends/server/protocols/http/HTTPClientConnection.java | 24 ++++--------------------
2 files changed, 5 insertions(+), 21 deletions(-)
diff --git a/opendj-server-legacy/src/main/java/org/opends/server/loggers/TextHTTPAccessLogPublisher.java b/opendj-server-legacy/src/main/java/org/opends/server/loggers/TextHTTPAccessLogPublisher.java
index 1670a06..b781c79 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/loggers/TextHTTPAccessLogPublisher.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/loggers/TextHTTPAccessLogPublisher.java
@@ -269,7 +269,7 @@
/**
* Returns a new Collection containing a - b.
*
- * @param <T>
+ * @param <T> The type of collection elements.
* @param a
* the collection to subtract from, must not be null
* @param b
diff --git a/opendj-server-legacy/src/main/java/org/opends/server/protocols/http/HTTPClientConnection.java b/opendj-server-legacy/src/main/java/org/opends/server/protocols/http/HTTPClientConnection.java
index 05ac615..e0df0b2 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/protocols/http/HTTPClientConnection.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/protocols/http/HTTPClientConnection.java
@@ -103,7 +103,7 @@
final Operation operation;
final LdapPromiseImpl<Result> promise;
- public OperationWithPromise(Operation operation, LdapPromiseImpl<Result> promise)
+ private OperationWithPromise(Operation operation, LdapPromiseImpl<Result> promise)
{
this.operation = operation;
this.promise = promise;
@@ -122,7 +122,7 @@
final SearchResultHandler entryHandler;
- public SearchOperationWithPromise(
+ private SearchOperationWithPromise(
Operation operation, LdapPromiseImpl<Result> promise, SearchResultHandler entryHandler)
{
super(operation, promise);
@@ -210,9 +210,6 @@
/** The client (remote) address. */
private final String clientAddress;
- /** The client (remote) host name. */
- private String clientHost;
-
/** The client (remote) port. */
private final int clientPort;
@@ -222,9 +219,6 @@
/** The server (local) address. */
private final String serverAddress;
- /** The server (local) host name. */
- private String serverHost;
-
/** The server (local) port. */
private final int serverPort;
@@ -339,7 +333,7 @@
@Override
public String getClientHost()
{
- return clientHost;
+ return clientAddress; // Avoid reverse lookups.
}
@Override
@@ -357,7 +351,7 @@
@Override
public String getServerHost()
{
- return serverHost;
+ return serverAddress; // Avoid reverse lookups.
}
@Override
@@ -821,16 +815,6 @@
buffer.append(getServerAddress()).append(":").append(getServerPort());
}
- /**
- * Returns the statTracker for this connection handler.
- *
- * @return the statTracker for this connection handler
- */
- public HTTPStatistics getStatTracker()
- {
- return statTracker;
- }
-
@Override
public int getSSF()
{
--
Gitblit v1.10.0