From cd098d8be331e52041d608ebebfa15bbf6e61084 Mon Sep 17 00:00:00 2001
From: Matthew Swift <matthew.swift@forgerock.com>
Date: Thu, 17 Dec 2015 11:37:43 +0000
Subject: [PATCH] Minor code cleanup

---
 opendj-server-legacy/src/main/java/org/opends/server/types/NamedCharacterSet.java |   25 ++++---------------------
 1 files changed, 4 insertions(+), 21 deletions(-)

diff --git a/opendj-server-legacy/src/main/java/org/opends/server/types/NamedCharacterSet.java b/opendj-server-legacy/src/main/java/org/opends/server/types/NamedCharacterSet.java
index e2d2f29..1b796f3 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/types/NamedCharacterSet.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/types/NamedCharacterSet.java
@@ -53,13 +53,13 @@
 public final class NamedCharacterSet
 {
   /** The characters contained in this character set. */
-  private char[] characters;
+  private final char[] characters;
 
   /** The random number generator to use with this character set. */
-  private Random random;
+  private final Random random;
 
   /** The name assigned to this character set. */
-  private String name;
+  private final String name;
 
 
 
@@ -76,24 +76,7 @@
   public NamedCharacterSet(String name, char[] characters)
          throws ConfigException
   {
-    this.name       = name;
-    this.characters = characters;
-
-    random     = new Random();
-
-    if (name == null || name.length() == 0)
-    {
-      LocalizableMessage message = ERR_CHARSET_CONSTRUCTOR_NO_NAME.get();
-      throw new ConfigException(message);
-    }
-
-    for (int i=0; i < name.length(); i++)
-    {
-      if (! isAlpha(name.charAt(i)))
-      {
-        throw new ConfigException(ERR_CHARSET_CONSTRUCTOR_INVALID_NAME_CHAR.get(name.charAt(i), i));
-      }
-    }
+    this(name, characters, new Random());
   }
 
 

--
Gitblit v1.10.0