From efd4613df62d37aa785a78a78cdc89c28f24f5cd Mon Sep 17 00:00:00 2001
From: matthew_swift <matthew_swift@localhost>
Date: Thu, 09 Sep 2010 17:31:33 +0000
Subject: [PATCH] Allow multiple percentile arguments and remove arbitrary 50% lower bound.
---
sdk/src/com/sun/opends/sdk/tools/PerformanceRunner.java | 3 ++-
sdk/src/com/sun/opends/sdk/tools/IntegerArgument.java | 8 +++-----
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/sdk/src/com/sun/opends/sdk/tools/IntegerArgument.java b/sdk/src/com/sun/opends/sdk/tools/IntegerArgument.java
index 9681ddf..10c616a 100644
--- a/sdk/src/com/sun/opends/sdk/tools/IntegerArgument.java
+++ b/sdk/src/com/sun/opends/sdk/tools/IntegerArgument.java
@@ -22,7 +22,7 @@
* CDDL HEADER END
*
*
- * Copyright 2006-2008 Sun Microsystems, Inc.
+ * Copyright 2006-2010 Sun Microsystems, Inc.
*/
package com.sun.opends.sdk.tools;
@@ -512,8 +512,7 @@
}
// If there is a lower bound, then the value must be greater than or
- // equal
- // to it.
+ // equal to it.
if (hasLowerBound && (intValue < lowerBound))
{
invalidReason.append(ERR_INTARG_VALUE_BELOW_LOWER_BOUND.get(getName(),
@@ -522,8 +521,7 @@
}
// If there is an upper bound, then the value must be less than or
- // equal to
- // it.
+ // equal to it.
if (hasUpperBound && (intValue > upperBound))
{
diff --git a/sdk/src/com/sun/opends/sdk/tools/PerformanceRunner.java b/sdk/src/com/sun/opends/sdk/tools/PerformanceRunner.java
index 24b5f56..c5d9206 100644
--- a/sdk/src/com/sun/opends/sdk/tools/PerformanceRunner.java
+++ b/sdk/src/com/sun/opends/sdk/tools/PerformanceRunner.java
@@ -835,10 +835,11 @@
argParser.addArgument(targetThroughputArgument);
percentilesArgument = new IntegerArgument("percentile", 'e', "percentile",
- false, true, LocalizableMessage.raw("{percentile}"), true, 50, true,
+ false, true, LocalizableMessage.raw("{percentile}"), true, 0, true,
100, LocalizableMessage.raw("Calculate max response time for a "
+ "percentile of operations"));
percentilesArgument.setPropertyName("percentile");
+ percentilesArgument.setMultiValued(true);
argParser.addArgument(percentilesArgument);
keepConnectionsOpen = new BooleanArgument("keepConnectionsOpen", 'f',
--
Gitblit v1.10.0